All: Fixes #12362: Fixes resources linked with Windows path not being imported #12386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedr
added
bug
laurent22
reviewed
Jun 6, 2025
packages/utils/path.test.ts
Outdated
| @@ -73,4 +73,5 @@ describe('path', () => { | |||
| ])('should correctly detect UNC paths', (path, os, expected) => { | |||
| expect(isUncPath(path, os)).toBe(expected); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Please remove white space change
…standing-windows-path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12362
Summary
When testing the chinese evernote (yinxiang) we discovered that some images were not being imported. The problem is that these particular images are using a Windows path link
Note name\path_to_image.pngwhich is not something the MD/HTML importer seems to handle at the moment.I created a new function in utils to converter the Windows path to POSIX and created some tests for it and for the scenario that surfaced this bug.