Skip to content

Remove CSV parsing code #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

Remove CSV parsing code #78

merged 1 commit into from
Sep 26, 2024

Conversation

medley56
Copy link
Member

@medley56 medley56 commented Sep 25, 2024 •
edited
Loading

Remove CSV Definition

Removed the CSV Definition class entirely and all associated deprecated methods on the parser. Converted the parsing test for CTIM to use an XTCE definition instead of a CSV definition.

Checklist

  • Changes are fully implemented without dangling issues or TODO items
  • Deprecated/superseded code is removed or marked with deprecation warning
  • [NA] Current dependencies have been properly specified and old dependencies removed
  • New code/functionality has accompanying tests and any old tests have been updated to match any new assumptions
  • The changelog.md has been updated

@medley56 medley56 linked an issue Sep 25, 2024 that may be closed by this pull request
Disposition CSV-based packet definition code #40
Closed
@medley56 medley56 force-pushed the 40-disposition-csv-based-packet-definition-code branch 8 times, most recently from cfa0d77 to 1fc5b16 Compare September 25, 2024 23:36
@medley56 medley56 marked this pull request as ready for review September 25, 2024 23:38
@medley56 medley56 mentioned this pull request Sep 26, 2024
Merged
5 tasks
greglucas
greglucas approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some minor nit comments you can take/leave as you like.

@medley56 medley56 force-pushed the 40-disposition-csv-based-packet-definition-code branch from 1fc5b16 to 86c662a Compare September 26, 2024 11:58
@medley56
Remove CSV parsing code and test CSV definition
3e4f74b 
Add CTIM XTCE document for CTIM parsing test
Consolidate Actions workflow into a single test with multiple jobs
@medley56 medley56 force-pushed the 40-disposition-csv-based-packet-definition-code branch from 86c662a to 3e4f74b Compare September 26, 2024 15:27
@medley56 medley56 merged commit 327e7df into main Sep 26, 2024
7 checks passed
@medley56 medley56 deleted the 40-disposition-csv-based-packet-definition-code branch September 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disposition CSV-based packet definition code
2 participants
@medley56 @greglucas