Skip to content

Support MIL-1750A Float Encoding #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2024
Merged

Support MIL-1750A Float Encoding #69

merged 1 commit into from
Sep 5, 2024

Conversation

medley56
Copy link
Member

@medley56 medley56 commented Sep 4, 2024 •
edited
Loading

Support MIL-1750A Float Encoding

Bump python requirement to 3.9 and remove 3.8 tests and github workflow
Add support for MIL-1750A float parsing
Add test cases pulled from MIL-1750A standard document

Checklist

  • Changes are fully implemented without dangling issues or TODO items
  • Deprecated/superseded code is removed or marked with deprecation warning
  • Current dependencies have been properly specified and old dependencies removed
  • New code/functionality has accompanying tests and any old tests have been updated to match any new assumptions
  • The changelog.md has been updated

@medley56 medley56 linked an issue Sep 4, 2024 that may be closed by this pull request
Support MIL-1750A Float Encodings #66
Closed
@medley56 medley56 force-pushed the 66-support-mil-1750a-float-encodings branch 2 times, most recently from c3b00ee to a407a2f Compare September 5, 2024 00:04
greglucas
greglucas approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I've just got a few minor suggestions. We should decide what we want private vs public interfaces.

@medley56
Bump python requirement to 3.9 and remove 3.8 tests and github workflow
7682186 
Add support for MIL-1750A float parsing
Add test cases pulled from MIL-1750A standard document
@medley56 medley56 force-pushed the 66-support-mil-1750a-float-encodings branch from a407a2f to 7682186 Compare September 5, 2024 15:52
@medley56
Copy link
Member Author

medley56 commented Sep 5, 2024

@greglucas Updated and ready for final review.

@medley56 medley56 merged commit ab0f361 into main Sep 5, 2024
7 checks passed
@medley56 medley56 deleted the 66-support-mil-1750a-float-encodings branch September 5, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MIL-1750A Float Encodings
2 participants
@medley56 @greglucas