Skip to content

Conversation

medley56
Copy link
Member

@medley56 medley56 commented Mar 8, 2025

I noticed that we had low-ish coverage on a couple modules, mostly on the error-handling since most of the tests are run correctly. I found some locations where we were checking for exception cases in evaluate methods when we should have been pre-checking in either init or from_xml.

I added some additional coverage to the packets.py module but I'm thinking that will probably need rework after @greglucas 's refactoring in #140

Checklist

  • Changes are fully implemented without dangling issues or TODO items
  • Deprecated/superseded code is removed or marked with deprecation warning
  • Current dependencies have been properly specified and old dependencies removed
  • New code/functionality has accompanying tests and any old tests have been updated to match any new assumptions
  • [NA] The changelog.md has been updated

@medley56 medley56 requested a review from greglucas March 8, 2025 00:43
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (bc05878) to head (9cee12e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   91.89%   93.43%   +1.54%     
==========================================
  Files          36       37       +1     
  Lines        2553     2605      +52     
==========================================
+ Hits         2346     2434      +88     
+ Misses        207      171      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@medley56 medley56 force-pushed the improve-unit-test-coverage branch from 94affac to ccfcd65 Compare March 8, 2025 00:46
- Improve coverage of comparisons and remove unnecessary checks in their evaluate methods (in parsing loop)
- Improve coverage of encodings
- Improve coverage of packets
- Add coverage for minimum dtype functions in xarr module
@medley56 medley56 force-pushed the improve-unit-test-coverage branch from 37989ab to 9cee12e Compare March 8, 2025 05:05
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, one of us will have to fix some merge conflicts, but overall this doesn't seem like it will cause too much headache CCSDSPacket -> Packet mostly.

@medley56 medley56 merged commit 7d9468a into main Mar 11, 2025
19 checks passed
@medley56 medley56 deleted the improve-unit-test-coverage branch March 11, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants