-
Notifications
You must be signed in to change notification settings - Fork 7
Handle all namespace cases - default, prefixed, no namespace. #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54e5a15
to
e7f220d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about namespaces or XML, so most of my comments are just my ignorance of it all. Feel free to dismiss or ignore. Overall, I really like that this gets rid of the ns
showing up everywhere and think it will simplify things moving forward!
tests/integration/test_xtce_based_parsing/test_inheritance_restrictions.py
Outdated
Show resolved
Hide resolved
79aef35
to
87288dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=========================================
+ Coverage 0 91.82% +91.82%
=========================================
Files 0 35 +35
Lines 0 2543 +2543
=========================================
+ Hits 0 2335 +2335
- Misses 0 208 +208 ☔ View full report in Codecov by Sentry. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, this looks super helpful and is much appreciated to remove all the required "ns" passing. Thank you for looking into this. All of my minor code-formatting comments have been addressed. I think the logic seems sound, but I don't have enough experience to fully verify that is the best approach. I think we should get this in sooner rather than later due to the amount of code it touches by just removing "ns=" in so many places. We can iterate on the little things later because it is mostly non-user facing.
Checklist