Skip to content

Conversation

cgobat
Copy link
Collaborator

@cgobat cgobat commented Feb 5, 2025

Checklist

  • Changes are fully implemented without dangling issues or TODO items
  • Deprecated/superseded code is removed or marked with deprecation warning
    • N/A
  • Current dependencies have been properly specified and old dependencies removed
  • New code/functionality has accompanying tests and any old tests have been updated to match any new assumptions
  • The changelog.md has been updated

This PR resolves the issue I raised in my comment here.

@greglucas greglucas linked an issue Feb 5, 2025 that may be closed by this pull request
@cgobat
Copy link
Collaborator Author

cgobat commented Feb 7, 2025

Could you run tests/CI on this again?

@medley56
Copy link
Member

medley56 commented Feb 7, 2025

@cgobat I just added you as a Collaborator. You should be able to run the CI tests now.

Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding in that soft deprecation of the wrong labels. I think this looks great!

There is one linting fix which you can get locally with ruff --fix space_packet_parser I think.

@cgobat cgobat marked this pull request as ready for review February 7, 2025 20:59
@cgobat cgobat requested a review from medley56 as a code owner February 7, 2025 20:59
@greglucas greglucas merged commit 79cd5d3 into lasp:main Feb 7, 2025
17 checks passed
@greglucas
Copy link
Collaborator

@cgobat, thanks! Also as an FYI, we just moved this over to the "lasp" GitHub organization, so you may want to update your upstream location when pulling/rebasing.

@cgobat cgobat deleted the bugfix/allowed-float-encodings branch February 7, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Float names in XTCE enumerations
3 participants