-
Notifications
You must be signed in to change notification settings - Fork 7
BUGFIX: update allowed float encodings to match XTCE standard #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you run tests/CI on this again? |
@cgobat I just added you as a Collaborator. You should be able to run the CI tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding in that soft deprecation of the wrong labels. I think this looks great!
There is one linting fix which you can get locally with ruff --fix space_packet_parser
I think.
@cgobat, thanks! Also as an FYI, we just moved this over to the "lasp" GitHub organization, so you may want to update your upstream location when pulling/rebasing. |
Checklist
This PR resolves the issue I raised in my comment here.