Remote headers #16
Open
Remote headers #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-git into remote-headers
…-git into remote-headers
Owner
|
I apologize for introducing conflicts into your merge request. But the whole platform abstraction was icky cubed. |
| last_page[LAST_REFCOUNTLINK].link = new_page; | ||
| new_page[0].link = last_page; | ||
| last_page = new_page; | ||
| diff = &new_page[1] - &new_page[0]; |
There was a problem hiding this comment.
This looks like a sizeof(refcountlink) to me, why do it this way?
Author
There was a problem hiding this comment.
It's sizeof(refcountlink) only when the size is a multiple of the alignment. This automatically takes care of the alignment.
Author
|
FYI, I'm still working on this, but as a patch to regular trunk first -- so that I can test it more broadly than gilectomy allows. This version of the patch has a few leaks, at least (Py_ForgetReference() isn't always called). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement remote refcounts, storing a pointer to a refcount, which are allocated in blocks. The blocks aren't freed and there is no detection of refcount-value-leaks (different from refleaks) just yet. I have things in mind for both of them.