Skip to content

Conversation

Tombana
Copy link
Collaborator

@Tombana Tombana commented Jun 20, 2024

What do these changes do?

Add Python 3.12 to the release builds and use Python 3.12 in regular CI.
I made Python 3.10 the minimal version so that we still support the latest 3 Python versions, similar to the previous release.

The testrelease is running here: https://github.com/larq/compute-engine/actions/runs/9596990350

Use Python 3.12 in regular CI
@Tombana Tombana requested review from CNugteren and lgeiger June 20, 2024 11:58
@Tombana Tombana added dependencies Pull requests that update a dependency file internal-improvement Internal Improvements and Maintenance python Pull requests that update Python code labels Jun 20, 2024
Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Tombana
Copy link
Collaborator Author

Tombana commented Jun 20, 2024

It seems that the locked requirements.txt file is quite different for Python 3.12. Perhaps we should do the same as what TF does and have separate requirements_{python_version}.txt files.

@Tombana Tombana merged commit 44f66a9 into main Jun 20, 2024
@Tombana Tombana deleted the python-3.12 branch June 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal-improvement Internal Improvements and Maintenance python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants