⬆️ [email protected] #784
Merged
⬆️ [email protected] #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting an example model
This reverts commit 1e0859b.
Tombana
approved these changes
Aug 4, 2023
lgeiger
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This updates TensorFlow from version 2.11 to 2.13 (note that 2.12 was skipped, so this is a double update). The code was updated to make it compile and run again.
I checked the diff for
tf_tfl_passes.ccto see if we need to update anything but I don't think it is significant. You can see it for yourself with (in thethird_party/tensorflowfolder):I removed
third_party/tensorflow_patches/embedded_toolchain.patch(from #749) since I believe that same patch has been applied to the mainline TensorFlow already. And I updatedthird_party/tensorflow_patches/disable_forced_mkl.patch(from #666) because that file is now completely different.I also removed all dependencies on the https://github.com/larq/zoo from this repository, since it isn't currently compatible with TF 2.13 (although we have a fix). To make things easier in the future as well, I thought it is best to remove the dependency. If you think otherwise, we can revert these changes and wait for a new larq-zoo release.
How Has This Been Tested?
I ran some of the compilation and tests locally, but CI should be able to cover everything.
Benchmark Results
I did not convert any models to see if there are issues with them.
Related issue number
https://github.com/plumerai/lce-micro/issues/1358 (internal issue)