Skip to content

Increase minimal macOS version requirement #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

Increase minimal macOS version requirement #753

merged 1 commit into from
Sep 9, 2022

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Sep 9, 2022

This PR increases the minimal macOS version requirement to 10.14.
This should fix the following error that I am seeing in our test build:

error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.14 or newer

Judging from the pip wheel names TensorFlow is doing the same since 2.8.

@lgeiger lgeiger added the internal-improvement Internal Improvements and Maintenance label Sep 9, 2022
@lgeiger lgeiger requested a review from a team September 9, 2022 11:16
@lgeiger lgeiger merged commit bd61a92 into main Sep 9, 2022
@lgeiger lgeiger deleted the macosx-10-14 branch September 9, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tombana Tombana Tombana approved these changes

Assignees
No one assigned
Labels
internal-improvement Internal Improvements and Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgeiger @Tombana