-
Notifications
You must be signed in to change notification settings - Fork 35
Add bazel cache for release jobs #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New run with different folders for each python version, and with passing the credentials into the manylinux container: https://github.com/larq/compute-engine/actions/runs/2200491384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I just have one minor comment, other than that this looks great!
- name: Build macOS wheels | ||
run: | | ||
python --version | ||
python -m pip install delocate wheel setuptools numpy six --no-cache-dir | ||
|
||
./configure.py | ||
|
||
if [[ -n $GOOGLE_APPLICATION_CREDENTIALS ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the release workflow this should always exist, but I agree it's probably good to keep this check just to be safe.
On the previous run only the python 3.7 job failed with an internal gcc error. |
The cache is working but not completely: the builds take about ~25 minutes, so something is working but it's still rebuilding some parts. |
25 minutes should be good enough. It saves a lot of time, and it makes the Windows builds pass. However I still see some builds ongoing at the moment, so some might take longer? |
Indeed. I don't really know why the cache is only partially working, but I think this PR can be merged nonetheless, as it already helps. |
What do these changes do?
This adds a bazel cache for release jobs:
How Has This Been Tested?
It is running here: https://github.com/larq/compute-engine/actions/runs/2200323727