Configure the Android SDK/NDK interactively in configure.py. #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we don't have to hard-code paths, and Android only needs to be configured when necessary. Configuration code taken from TF. Closes larq#598.
lgeiger
approved these changes
Apr 10, 2021
Yes these functions are lifted verbatim 👍 |
Tombana
approved these changes
Apr 12, 2021
CNugteren
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we don't have to hard-code paths, and Android only needs to be configured when necessary (it won't be configured by default). Configuration code taken from TF.
Hopefully closes #598, which is a prerequisite for upgrading to Bazel 3.7, which is a prerequisite for upgrading to TF 2.5.