[12.x] Make built-in functions be callable with collection callbacks whose parameter count doesn't fit #56525
+41
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter count doesn't fit
…with-collection-callbacks-easier
shaedrich
changed the title
to cover more types of callables
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
shaedrich
added a commit
to shaedrich/framework
that referenced
this pull request
Aug 3, 2025
…smatch because we can't have nice things like laravel#56525
taylorotwell
pushed a commit
that referenced
this pull request
Aug 4, 2025
* Add Arr::some() and Arr::every() * Add tests for `Arr::some()` and `Arr::every()` * Fix first-class callable for built-in function with argument count mismatch because we can't have nice things like #56525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Built-in or internal functions, unlike userland functions, must be called with the proper number of arguments. Userland functions can discard additional arguments on their own.
Solution
This PR introduces the internal wrapper utility for certain methods to align built-in function behavior with their userland counterparts, callback function calls with callables have to be wrapped in this function to not throw an exception.