Cloning request as PSR-7 with body of an array of objects results in duplicated objects

[ineptvagrant]

Came across this while trouble shooting why Sentry is reporting a body with duplicated payload objects.

per documentation https://laravel.com/docs/12.x/requests#psr7-requests
composer require nyholm/psr7

If the body is an array of objects, then the new parsed body is an array with duplicated object(s)

curl --header "Content-Type: application/json" \
  --request POST \
  --data '[{"test": "1"}]' \
  https://api.something.com/receive

$newRequest = Container::getInstance()->make(ServerRequestInterface::class);

$newRequest->getParsedBody()
result = {array[2]} 
 0 = {array[1]} 
  test = "1"
 1 = {array[1]} 
  test = "1"

Traced to here

framework/src/Illuminate/Routing/RoutingServiceProvider.php

Line 144 in 868c1f2

array_merge($request->getParsedBody() ?? [], $illuminateRequest->getPayload()->all())

[crynobone]

This is expected to handle changes upstream (Symfony HTTP Foundation): #49047

I don't see anywhere in $newRequest = Container::getInstance()->make(ServerRequestInterface::class); is needed, can you elaborate more and send it a reproduction repository.

[crynobone]

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

[ineptvagrant]

This test reproduced using laravel new bug-report --github="--public" (the test harness in #49047 is a little different)

/app/vendor/phpunit/phpunit/phpunit --configuration /app/phpunit.xml --filter "/(Tests\\Unit\\ExampleTest::testWhatever)( .*)?$/" --test-suffix ExampleTest.php /app/bug-report/tests/Unit --teamcity
Testing started at 10:34 AM ...
PHPUnit 12.3.6 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.24
Configuration: /app/phpunit.xml


Failed asserting that actual size 2 matches expected size 1.
/app/bug-report/tests/Unit/ExampleTest.php:33

Time: 00:00.558, Memory: 129.00 MB

    public function testWhatever(): void
    {
        Route::post('test-route', function (ServerRequestInterface $request) {
            return $request->getParsedBody();
        });

        $response = $this->postJson('test-route', [
            (object)['test' => 1],
        ]);

        $response->assertOk();
        $responseBody = $response->getContent();
        $responseParse = json_decode($responseBody);
        $this->assertIsArray($responseParse);
        $this->assertCount(1, $responseParse);
        $this->assertCount(1, array_keys($responseParse[0]));
        $this->assertArrayHasKey('test', $responseParse[0]);
        $this->assertEquals(1, $responseParse[0]['test']);
    }

Reference: #49047

                    ->createRequest($illuminateRequest = $app->make('request')), function (ServerRequestInterface $request) use ($illuminateRequest) {
                        if ($illuminateRequest->getContentTypeFormat() !== 'json' && $illuminateRequest->request->count() === 0) {
                            return $request;
                        }

                        return $request->withParsedBody(
                            array_merge($request->getParsedBody() ?? [], $illuminateRequest->getPayload()->all())
                        );
                    });

$app->make('request') returns a request then passes into the callback

$request->getParsedBody() returns the array [0 => {'test' => 1}]

$illuminateRequest->getPayload()->all() returns the array [0 => {'test' => 1}] also

then array_merge([0 => {'test' => 1}] ?? [], [0 => {'test' => 1}]) returns [0 => {'test' => 1}, 1 => {'test' => 1}]

finally, $request->withParsedBody([0 => {'test' => 1}, 1 => {'test' => 1}]) ends with a parsed body with duplicated objects

Note: it works fine if the body is a json object, instead of a json array, in which case array_merge acts on string keys, instead of int keys