This repository was archived by the owner on Jun 29, 2021. It is now read-only.
Resolves #32 - A guest or an authenticated user can list answers of a question #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/ana-lisboa/api into FEAT/laravel-portugal#32/GetAnswersFromAQuestion
josepostiga
changed the title
josepostiga
suggested changes
Nov 2, 2020
There was a problem hiding this comment.
Thanks for this @ana-lisboa! I've made a few notes to improve your work that I'd like you to tackle, before aligning this PR to be merged. 😉
domains/Discussions/Controllers/QuestionsGetAnswersController.php
Outdated
Show resolved
Hide resolved
domains/Discussions/Controllers/QuestionsGetAnswersController.php
Outdated
Show resolved
Hide resolved
domains/Discussions/Controllers/QuestionsGetAnswersController.php
Outdated
Show resolved
Hide resolved
domains/Discussions/Controllers/QuestionsGetAnswersController.php
Outdated
Show resolved
Hide resolved
josepostiga
suggested changes
Nov 6, 2020
domains/Discussions/Tests/Feature/AnswersIndexControllerTest.php
Outdated
Show resolved
Hide resolved
domains/Discussions/Tests/Feature/AnswersIndexControllerTest.php
Outdated
Show resolved
Hide resolved
josepostiga
suggested changes
Nov 9, 2020
domains/Discussions/Tests/Feature/AnswersIndexControllerTest.php
Outdated
Show resolved
Hide resolved
domains/Discussions/Tests/Feature/AnswersIndexControllerTest.php
Outdated
Show resolved
Hide resolved
|
Some more alterations done, from the feedback received. The first test is still failing. |
|
Thanks for this @ana-lisboa. Can you just update the CHANGELOG file withe the updates we're making, here? |
|
Absolutely!
Cumprimentos,
Ana Lisboa
A quinta, 19/11/2020, 09:46, José Postiga <[email protected]>
escreveu:
… Thanks for this @ana-lisboa <https://github.com/ana-lisboa>. Can you just
update the CHANGELOG file withe the updates we're making, here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4HBOXVK4SJV6KTTVH7323SQTSRHANCNFSM4TGZP6AQ>
.
|
added! |
…estion # Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.