Debug magma on crusher #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnegre
approved these changes
Feb 6, 2023
nicolasbock
requested changes
Feb 7, 2023
| @@ -35,7 +35,6 @@ EOF | |||
| echo "CC Path to C compiler (default is ${CC})" | |||
| echo "CXX Path to C++ compiler (default is ${CXX})" | |||
| echo "FC Path to Fortran compiler (default is ${FC})" | |||
| echo "BML_ROCSPARSE Build with rocSPARSE (default is ${BML_ROCSPARSE})" | |||
There was a problem hiding this comment.
Why do you remove this line? The variable BML_ROCSPARSE is still being used.
mewall
force-pushed
the
crusher_magma_debug
branch
from
64ff5ea to
48c9a7c
Compare
|
Thanks for catching that. It's not needed any more with the BML package revision. I changed CMakelists.txt and removed other refs to BML_ROCSPARSE in build.sh.
________________________________
From: Nicolas Bock ***@***.***>
Sent: Monday, February 6, 2023 8:40:46 PM
To: lanl/qmd-progress
Cc: Wall, Michael E; Author
Subject: [EXTERNAL] Re: [lanl/qmd-progress] Debug magma on crusher (PR #244)
@nicolasbock requested changes on this pull request.
________________________________
In build.sh<https://urldefense.com/v3/__https://github.com/lanl/qmd-progress/pull/244*discussion_r1098141880__;Iw!!Bt8fGhp8LhKGRg!GreLoMHHsVkwIcvpco7_fIFJAgJBpHYRw2ODkVLiLLTFT834Owq6V8GhroEyQXznYG2Uf5pfWOoZUaRrPOo4jWrj$>:
@@ -35,7 +35,6 @@ EOF
echo "CC Path to C compiler (default is ${CC})"
echo "CXX Path to C++ compiler (default is ${CXX})"
echo "FC Path to Fortran compiler (default is ${FC})"
- echo "BML_ROCSPARSE Build with rocSPARSE (default is ${BML_ROCSPARSE})"
Why do you remove this line? The variable BML_ROCSPARSE is still being used.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/lanl/qmd-progress/pull/244*pullrequestreview-1286337475__;Iw!!Bt8fGhp8LhKGRg!GreLoMHHsVkwIcvpco7_fIFJAgJBpHYRw2ODkVLiLLTFT834Owq6V8GhroEyQXznYG2Uf5pfWOoZUaRrPHDSUBDd$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AA67VEP2UJZPN5DIKE34WFLWWG735ANCNFSM6AAAAAAUSXV35U__;!!Bt8fGhp8LhKGRg!GreLoMHHsVkwIcvpco7_fIFJAgJBpHYRw2ODkVLiLLTFT834Owq6V8GhroEyQXznYG2Uf5pfWOoZUaRrPPSUZIXC$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jeanlucf22
requested changes
Feb 7, 2023
|
The BML package now handles the rocSPARSE dependency. Please see the note on the commit with reference to the BML PR#...
…________________________________
From: Jean-Luc Fattebert ***@***.***>
Sent: Tuesday, February 7, 2023 8:19:04 AM
To: lanl/qmd-progress
Cc: Wall, Michael E; Author
Subject: [EXTERNAL] Re: [lanl/qmd-progress] Debug magma on crusher (PR #244)
@jeanlucf22 requested changes on this pull request.
What do you mean? Are we dropping off support for rocsparse?
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/lanl/qmd-progress/pull/244*pullrequestreview-1287319071__;Iw!!Bt8fGhp8LhKGRg!Cgurs-KnpHTWOaT5-D7YvWAtXwu34CRZa2eS8tJnA7lf5Z1URilttfFzwve7xTmx2d-Da1tzhKaxiYZ1n5aH_Ky2$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AA67VEJVLBBZFEDGXZXOMITWWJRWRANCNFSM6AAAAAAUSXV35U__;!!Bt8fGhp8LhKGRg!Cgurs-KnpHTWOaT5-D7YvWAtXwu34CRZa2eS8tJnA7lf5Z1URilttfFzwve7xTmx2d-Da1tzhKaxiYZ1nz0yrX6s$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
… ________________________________
From: Wall, Michael E
Sent: Tuesday, February 7, 2023 8:24:57 AM
To: lanl/qmd-progress; lanl/qmd-progress
Cc: Author
Subject: Re: [EXTERNAL] Re: [lanl/qmd-progress] Debug magma on crusher (PR #244)
The BML package now handles the rocSPARSE dependency. Please see the note on the commit with reference to the BML PR#...
________________________________
From: Jean-Luc Fattebert ***@***.***>
Sent: Tuesday, February 7, 2023 8:19:04 AM
To: lanl/qmd-progress
Cc: Wall, Michael E; Author
Subject: [EXTERNAL] Re: [lanl/qmd-progress] Debug magma on crusher (PR #244)
@jeanlucf22 requested changes on this pull request.
What do you mean? Are we dropping off support for rocsparse?
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/lanl/qmd-progress/pull/244*pullrequestreview-1287319071__;Iw!!Bt8fGhp8LhKGRg!Cgurs-KnpHTWOaT5-D7YvWAtXwu34CRZa2eS8tJnA7lf5Z1URilttfFzwve7xTmx2d-Da1tzhKaxiYZ1n5aH_Ky2$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AA67VEJVLBBZFEDGXZXOMITWWJRWRANCNFSM6AAAAAAUSXV35U__;!!Bt8fGhp8LhKGRg!Cgurs-KnpHTWOaT5-D7YvWAtXwu34CRZa2eS8tJnA7lf5Z1URilttfFzwve7xTmx2d-Da1tzhKaxiYZ1nz0yrX6s$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@mewall sorry, I thought I was looking at BML. I agree, rocsparse should not be anywehere in the build scripts here |
jeanlucf22
approved these changes
Feb 7, 2023
nicolasbock
requested changes
Feb 7, 2023
mewall
force-pushed
the
crusher_magma_debug
branch
from
48c9a7c to
f17a7d8
Compare
|
CI failures are not related to the PR (there is currently a "brownout" in CI for Bionic). I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to support cmake package bug fix for BML on OLCF crusher
This change is