Skip to content

Conversation

jeanlucf22
Copy link
Collaborator

@jeanlucf22 jeanlucf22 commented Feb 25, 2022

This is to resolve possible circular dependencies
and libraries order


This change is Reviewable

Copy link
Collaborator

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share an error message that shows what circular dependence we have? I am ok with merging this change if things are currently broken, but I think in the long run we should address the circular dependence if we can.

@jeanlucf22
Copy link
Collaborator Author

Takes care of issue #217

This is to resolve issues with libraries list order
@jeanlucf22
Copy link
Collaborator Author

@nicolasbock I updated my comments: I have not seen issues with circular dependencies, just with libraries list order

@cnegre cnegre merged commit e1dbc9e into lanl:master May 18, 2022
@jeanlucf22 jeanlucf22 deleted the bml_link branch September 14, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants