-
Notifications
You must be signed in to change notification settings - Fork 13
Implicit Fermi updated + trace_mult function change #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf501d5
to
467c706
Compare
Thanks @linneamk for the added test! |
@linneamk could you have a look at the test result though? I am getting:
Thanks! |
The implicit fermi test in progress was not passing because of the bml
library
not having the trace_mult. I guess it needs some debugging now that we have
that function.
…On Wed, Aug 21, 2019 at 11:54 AM Nicolas Bock ***@***.***> wrote:
Could you have a look at the test result though? I am getting:
Error in Implicit Fermi expansionError = 17.881605788278868
Note: The following floating-point exceptions are signalling: IEEE_UNDERFLOW_FLAG IEEE_DENORMAL
Thanks!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#136?email_source=notifications&email_token=AD2CLNO3SH7BUA27TA5K2OTQFV6NJA5CNFSM4IKOZZW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD42SPTI#issuecomment-523577293>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD2CLNLHEHLMZ4ONT73KLODQFV6NJANCNFSM4IKOZZWQ>
.
--
Dr. Christian F. A . Negre
LOS ALAMOS NATIONAL LABORATORY
T-1 Division, Mail Stop B221
Los Alamos, NM 87545
|
Ok, I will fix it. |
Thanks @linneamk |
The test hopefully works now. |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 40.67% 40.32% -0.35%
==========================================
Files 62 62
Lines 11754 12156 +402
Branches 1313 1339 +26
==========================================
+ Hits 4781 4902 +121
- Misses 6446 6719 +273
- Partials 527 535 +8
Continue to review full report at Codecov.
|
Also added input parameters and cleanup. Signed-off-by: Nicolas Bock <[email protected]>
Signed-off-by: Nicolas Bock <[email protected]>
c546c46
to
8276561
Compare
I removed the merge commit. |
Thanks for the fix @linneamk ! |
This change is