Skip to content

Conversation

linneamk
Copy link
Collaborator

@linneamk linneamk commented Aug 8, 2019

This change is Reviewable

@nicolasbock
Copy link
Collaborator

Thanks @linneamk for the added test!

@nicolasbock
Copy link
Collaborator

nicolasbock commented Aug 21, 2019

@linneamk could you have a look at the test result though? I am getting:

 Error in Implicit Fermi expansionError =    17.881605788278868     
Note: The following floating-point exceptions are signalling: IEEE_UNDERFLOW_FLAG IEEE_DENORMAL

Thanks!

@cnegre
Copy link
Collaborator

cnegre commented Aug 21, 2019 via email

@linneamk
Copy link
Collaborator Author

Ok, I will fix it.

@nicolasbock
Copy link
Collaborator

Thanks @linneamk

@linneamk
Copy link
Collaborator Author

The test hopefully works now.

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #136 into master will decrease coverage by 0.34%.
The diff coverage is 22.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   40.67%   40.32%   -0.35%     
==========================================
  Files          62       62              
  Lines       11754    12156     +402     
  Branches     1313     1339      +26     
==========================================
+ Hits         4781     4902     +121     
- Misses       6446     6719     +273     
- Partials      527      535       +8
Impacted Files Coverage Δ
examples/gploop/gploop.F90 0% <0%> (ø) ⬆️
examples/mdresponse/mdresponse.F90 0% <0%> (ø) ⬆️
examples/gpscf/gpscf.F90 0% <0%> (ø) ⬆️
examples/gptest/gptest.F90 0% <0%> (ø) ⬆️
examples/gpmd/gpmd.F90 61.47% <100%> (ø) ⬆️
src/prg_implicit_fermi_mod.F90 23.77% <21.14%> (+23.77%) ⬆️
tests/src/main.F90 82.37% <75%> (-0.16%) ⬇️
src/prg_normalize_mod.F90 76.31% <0%> (+13.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440048d...8276561. Read the comment docs.

@nicolasbock
Copy link
Collaborator

I removed the merge commit.

@nicolasbock
Copy link
Collaborator

Thanks for the fix @linneamk !

@nicolasbock nicolasbock merged commit fd210d4 into master Aug 26, 2019
@nicolasbock nicolasbock deleted the implicit_fermi_la branch August 26, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants