Skip to content

Remove unnecessary BLAS_VENDOR flag #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Conversation

nicolasbock
Copy link
Collaborator

@nicolasbock nicolasbock commented Jul 3, 2018

We don't use BLAS directly in qmd-progress so we might as well remove this variable from the CMakeLists.txt file.


This change is Reviewable

We don't use BLAS directly in qmd-progress so we might as well remove
this variable from the CMakeLists.txt file.
@nicolasbock nicolasbock requested review from cnegre and suemni as code owners July 3, 2018 21:20
@ghost ghost assigned nicolasbock Jul 3, 2018
@ghost ghost added the in progress label Jul 3, 2018
Copy link
Collaborator

@cnegre cnegre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this flag? And how is this going to impact the compilation using gnu vs mkl blas libs?

@nicolasbock
Copy link
Collaborator Author

We weren't using the flag at all (try running git grep -i blas_vendor). The BLAS libraries should come from the bml library. For some reason this last part is not quite working unfortunately. It does work on my laptop, but not on Travis.

@cnegre
Copy link
Collaborator

cnegre commented Jul 3, 2018 via email

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #124   +/-   ##
======================================
  Coverage    40.9%   40.9%           
======================================
  Files          62      62           
  Lines       11705   11705           
  Branches     1292    1292           
======================================
  Hits         4788    4788           
  Misses       6396    6396           
  Partials      521     521

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35654bf...fc87ca3. Read the comment docs.

@cnegre cnegre merged commit a0f0f49 into lanl:master Jul 9, 2018
@ghost ghost removed the in progress label Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants