Skip to content

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented May 24, 2025

Turns out that moduleResolution: node10 will achieve the same result as setting src/package.json to {} (verified via git worktrees).

Also switching moduleResolution: bundler for ESM build, after which I've compared the build output of libs/checkpoint via diff -r -q.

Turns out that `moduleResolution: node10` will achieve the same result as setting `src/package.json` to `{}` (verified via git worktrees).

Also switching `moduleResolution: bundler` for ESM build, after which I've compared the build output of `libs/checkpoint` via `diff -r -q`.
@dqbd dqbd merged commit 6f2a391 into main May 24, 2025
17 checks passed
@dqbd dqbd deleted the dqbd/ts-5.8 branch May 24, 2025 21:52
dqbd added a commit to langchain-ai/langchainjs that referenced this pull request Jun 5, 2025
Using similar tactics as in langchain-ai/langgraphjs#1216, with addition of following:

1. Fix new TypeScript errors that are actually valid bugs (unreachable code after `??`)
2. Dedupe packages such as `mongo`, `dpdm` etc. to avoid TypeScript resolution errors whenever possible (exception is Zep since it imports `langchain` as peerDep)
3. Add `@ts-ignore` flags to package imports that export types that are incompatible with CJS (@langchain/google-webauth, @langchain/ollama)
4. Fix default imports such as @langchain/anthropic, Neo4j etc. (`dep.default` -> `dep`)
dqbd added a commit to langchain-ai/langchainjs that referenced this pull request Jun 17, 2025
Using similar tactics as in langchain-ai/langgraphjs#1216, with addition of following:

1. Fix new TypeScript errors that are actually valid bugs (unreachable code after `??`)
2. Dedupe packages such as `mongo`, `dpdm` etc. to avoid TypeScript resolution errors whenever possible (exception is Zep since it imports `langchain` as peerDep)
3. Add `@ts-ignore` flags to package imports that export types that are incompatible with CJS (@langchain/google-webauth, @langchain/ollama)
4. Fix default imports such as @langchain/anthropic, Neo4j etc. (`dep.default` -> `dep`)

Fix format

Avoid circular dependency check for dynamic imports

Fix test

Add test for @langchain/google-gauth

Make as a peer dep
dqbd added a commit to langchain-ai/langchainjs that referenced this pull request Jun 17, 2025
Using similar tactics as in langchain-ai/langgraphjs#1216, with addition of following:

1. Fix new TypeScript errors that are actually valid bugs (unreachable code after `??`)
2. Dedupe packages such as `mongo`, `dpdm` etc. to avoid TypeScript resolution errors whenever possible (exception is Zep since it imports `langchain` as peerDep)
3. Add `@ts-ignore` flags to package imports that export types that are incompatible with CJS (@langchain/google-webauth, @langchain/ollama)
4. Fix default imports such as @langchain/anthropic, Neo4j etc. (`dep.default` -> `dep`)

Fix format

Avoid circular dependency check for dynamic imports

Fix test

Add test for @langchain/google-gauth

Make as a peer dep
JHZhang2736 pushed a commit to JHZhang2736/langchainjs that referenced this pull request Jul 1, 2025
Using similar tactics as in langchain-ai/langgraphjs#1216, with addition of following:

1. Fix new TypeScript errors that are actually valid bugs (unreachable code after `??`)
2. Dedupe packages such as `mongo`, `dpdm` etc. to avoid TypeScript resolution errors whenever possible (exception is Zep since it imports `langchain` as peerDep)
3. Add `@ts-ignore` flags to package imports that export types that are incompatible with CJS (@langchain/google-webauth, @langchain/ollama)
4. Fix default imports such as @langchain/anthropic, Neo4j etc. (`dep.default` -> `dep`)

Fix format

Avoid circular dependency check for dynamic imports

Fix test

Add test for @langchain/google-gauth

Make as a peer dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants