Skip to content

fix(mistral-ai): hub.pull with ChatMistralAI auto-instanciate #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2025
Merged

fix(mistral-ai): hub.pull with ChatMistralAI auto-instanciate #9081

merged 3 commits into from
Oct 1, 2025

Conversation

vincentmavieenlivre
Copy link
Contributor

@vincentmavieenlivre vincentmavieenlivre commented Sep 30, 2025 •
edited by hntrl
Loading

Fixes #9078

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 54445da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
langchain Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langchainjs-docs Ready Ready Preview Oct 1, 2025 10:05pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchainjs-api-refs Ignored Ignored Oct 1, 2025 10:05pm

@vincentmavieenlivre vincentmavieenlivre mentioned this pull request Sep 30, 2025
Merged
christian-bromann
christian-bromann reviewed Oct 1, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

Can we have a test for this so we don't regress here?

@vincentmavieenlivre
Copy link
Contributor Author

@christian-bromann it's first time i am contributing to langchain, i will see if i can setup the all environment to make the test. Hope it will be quick to setup :)

@christian-bromann
Copy link
Member

Sure thing, let me know if you have any questions.

@hntrl
Copy link
Member

hntrl commented Oct 1, 2025

Hey @vincentmavieenlivre!

Hope you don't mind, I pushed up some changes to add additional checks. Since we don't have a consistent pattern for testing loading models (yet), we're probably fine without tests for now.

@hntrl hntrl merged commit cabd762 into langchain-ai:main Oct 1, 2025
3 of 4 checks passed
@vincentmavieenlivre
Copy link
Contributor Author

Hey @vincentmavieenlivre!

Hope you don't mind, I pushed up some changes to add additional checks. Since we don't have a consistent pattern for testing loading models (yet), we're probably fine without tests for now.

Hey @hntrl sure, thanks a lot to have get the work done 🙏 !

hntrl added a commit that referenced this pull request Oct 14, 2025
@hntrl
chore(langchain/v1): patch changes
bb6311f 
* #9131
* #9093
* #9081
* #9069
* #9059
* #9057
* #9028
* #8978
* #8974
* #8966
* #8938
* #8932
* #8442
* #8863
* #8887
* #8849
* #8696
* #8850
* #8837
* #8719
* #8695
* #8634
@hntrl hntrl mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann left review comments

Assignees

No one assigned

Labels

langchain needs-v1-port

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hub.pull with includedModel: true using ChatMistralAI

3 participants

@vincentmavieenlivre @christian-bromann @hntrl