fix(core): make mustache prompt with nested object working correctly #8868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cf35293 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
taiichiro-nagase
changed the title
christian-bromann
approved these changes
Sep 8, 2025
hntrl
added a commit
that referenced
this pull request
Sep 9, 2025
|
@hntrl @christian-bromann thanks for the rapid review & merging! |
hntrl
added a commit
that referenced
this pull request
Sep 9, 2025
hntrl
added a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case that reveals a circumstance in which Mustache nested objects do not work correctly.Since I don't have a detailed enough understanding to make code changes, I'll start by adding test cases.This test case passes on @langchain/[email protected] which I'm using for now.This issue may be caused by the following PR: #8580.This PR fixes an mustache template issue that nested objects won't work correctly.