fix: add missing APAC region prefix in Bedrock models #8425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "apac" to AWS_REGIONS list in both chat models and LLMs - Add comprehensive test suite for model provider detection - Test various regional model prefixes (eu, apac, us-gov, us) - Ensure proper handling of different model ID formats and providers - Add validation for unsupported custom model ARNs This enables support for APAC-specific Bedrock model IDs like: apac.anthropic.claude-3-5-sonnet-20240620-v1:0
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
size:M
dosubot
bot
added
the
auto:bug
hntrl
requested changes
Jun 27, 2025
There was a problem hiding this comment.
Thanks @christian-bromann! Just one change to add Mexico to the supported regions, but otherwise LGTM
hntrl
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for APAC region prefix in Bedrock models
This enables support for APAC-specific Bedrock model IDs like:
apac.anthropic.claude-3-5-sonnet-20240620-v1:0This change resolves the issue where users in APAC regions couldn't use region-specific Bedrock model identifiers. Previously, attempting to use models with the
apac.prefix would result in an "Unknown model provider" error because the APAC region prefix wasn't recognized in the AWS_REGIONS configuration.The fix includes:
BedrockChatandBedrockLLM classesFixes #8408