Skip to content

fix(core): max event listeners error long running process #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(core): max event listeners error long running process #8366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions langchain-core/src/runnables/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,8 +931,10 @@ export abstract class Runnable<
// add each chunk to the output stream
const outerThis = this;
async function consumeRunnableStream() {
let signal;
let listener: (() => void) | null = null;

try {
let signal;
if (options?.signal) {
if ("any" in AbortSignal) {
// Use native AbortSignal.any() if available (Node 19+)
Expand All @@ -945,13 +947,12 @@ export abstract class Runnable<
// Fallback for Node 18 and below - just use the provided signal
signal = options.signal;
// Ensure we still abort our controller when the parent signal aborts
options.signal.addEventListener(
"abort",
() => {
abortController.abort();
},
{ once: true }
);

listener = () => {
abortController.abort();
};

options.signal.addEventListener("abort", listener, { once: true });
}
} else {
signal = abortController.signal;
Expand All @@ -971,6 +972,10 @@ export abstract class Runnable<
}
} finally {
await eventStreamer.finish();

if (signal && listener) {
signal.removeEventListener("abort", listener);
}
}
}
const runnableStreamConsumePromise = consumeRunnableStream();
Expand Down
Loading