Skip to content

Conversation

lbennett-stacki
Copy link
Contributor

Upgrades google-auth-library dep to latest major version (v10.1.0).

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 16, 2025
Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 9:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jun 16, 2025 9:22am

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Jun 16, 2025
@afirstenberg
Copy link
Contributor

#lgtm

@hntrl
Copy link
Member

hntrl commented Jun 16, 2025

@lbennett-stacki Looks like CI is failing after the upgrade. Do you mind taking a look?

@afirstenberg
Copy link
Contributor

afirstenberg commented Jun 16, 2025

To be clear, my lgtm was because tests ran without problems.

Looking at the code, langchain-google-gauth/src/auth.ts expects Gaxios handling, which is what "google-auth-library" 9 uses. With version 10, they're moving towards fetch() semantics, which means some of the types are broken. 10 is still Gaxios compatible - but apparently not type compatible.

The good news is that langchain-google-webauth uses fetch() as well and builds off a base class for it. So it may be easy to use this. Investigating further.

See googleapis/google-auth-library-nodejs#1938

@hntrl hntrl merged commit 723b56a into langchain-ai:main Jun 17, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants