475/simple sequential chain #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwkr
force-pushed
the
475/SimpleSequentialChain
branch
from
104f4eb to
3e8659c
Compare
kwkr
force-pushed
the
475/SimpleSequentialChain
branch
from
3e8659c to
078dbc2
Compare
nfcampos
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
@agola11 (not to do this in PR) but thoughts on adding a new callback method called handleChainIntermediateResult could be used in lots of places and might be a good answer for some things we've been discussing?
|
@kwkr outputKeys has been merged |
kwkr
force-pushed
the
475/SimpleSequentialChain
branch
from
078dbc2 to
e10c922
Compare
nfcampos
approved these changes
Apr 17, 2023
kwkr
force-pushed
the
475/SimpleSequentialChain
branch
from
e10c922 to
146b004
Compare
RohitMidha23
pushed a commit
to RohitMidha23/langchainjs
that referenced
this pull request
Apr 18, 2023
* add simple sequential chain implementation * add tests * add docs * fix linting errors * add full input chains validation --------- Co-authored-by: harry_squater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #475
Added SimpleSequentialChain implementation based on the one from the python version
This is my first PR here so please excuse me if I messed some conventions up. The functionality is there but due to some differences between Python and TS classes, I wasn't sure how should I proceed with the validation that is included in the Python version.
I also added the some example docs site for this specific class as it's done for the
LLM.Few things to consider:
outputKeyis not available on theBaseChainbut as a part of some chains (for exampleLLMChain). Because I usedBaseChainas a type of thechainsthat are passed to theSimpleSequentialChainthe way to check for this would be to do some casting and then check if the propertyoutputKeyis available on each chain. I would appreciate some input on how I should proceed with this.I would appreciate some hints on this @nfcampos. Thanks in advance for any input!