Skip to content

Conversation

MilanCancarevic
Copy link
Contributor

I was updating package '@langchain/google-genai' to 0.2.10 from 0.1.8 and noticed that docs are mentioning old param modelName. By looking at typings from ChatGoogleGenerativeAI i see that it has been renamed to model

GoogleGenerativeAIEmbeddingsParams has alias for both so this raises question should alias be supported for ChatGoogleGenerativeAI - if yes i would like to work on it

Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 6, 2025 10:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jun 6, 2025 10:48am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jun 6, 2025
@hntrl
Copy link
Member

hntrl commented Jun 13, 2025

Thanks for the change @MilanCancarevic!

Do you mean you want to see both modelName and model as params for ChatGoogleGenerativeAI? I'd call out that modelName is a broad deprecation that we have across all of langchain which will be removed in docs/examples/code in a later version. Some packages are more ahead than others in removing old deprecations in that regard.

@hntrl hntrl merged commit 2744a60 into langchain-ai:main Jun 13, 2025
3 checks passed
@MilanCancarevic
Copy link
Contributor Author

@hntrl I would prefer using model just so it's consistent, but since you are guys are already working on it then no changes are needed, thanks for making great framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants