ChatVertexAI: add prompt caching usage metadata #8320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:XS
|
A pretty quick win to monitor usage metadata for prompt caching. cc @jacoblee93 |
afirstenberg
reviewed
Jun 8, 2025
| output_tokens: usage?.output_tokens ?? 0, | ||
| total_tokens: (usage?.input_tokens ?? 0) + (usage?.output_tokens ?? 0), | ||
| cache_read_input_tokens: usage?.cache_read_input_tokens ?? 0, | ||
| cache_creation_input_tokens: usage?.cache_creation_input_tokens ?? 0, |
There was a problem hiding this comment.
I think that the usageMetadata object should be changed to meet the definitions of UsageMetadata, which I think was added since this function was created.
As such, the cache_read and cache_creation values should be set in the usageMetadata.input_token_details object.
This would have the Vertex+Anthropic support use the same standard the rest of LangChainJS is using.
There was a problem hiding this comment.
That makes sense tho, thanks for the heads up @afirstenberg! Updated the PR.
dosubot
bot
added
size:S
|
#lgtm |
|
@keremnalbant thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mapping for
cache_read_input_tokensandcache_creation_input_tokensforChatVertexAIclass.Fixes #8319