Skip to content

Conversation

@magick93
Copy link
Contributor

This adds an optional selector parameter to the load() function. The type is then specified in langchain/src/document_loaders/cheerio_web_base.ts

@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ❌ Failed (Inspect) Apr 12, 2023 8:45pm

Copy link
Collaborator

@nfcampos nfcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments

@nfcampos nfcampos added the question Further information is requested label Apr 11, 2023
@nfcampos
Copy link
Collaborator

Hi @magick93 can you give me permission to push to this branch (there should be a checkbox you can tick here in the PR page) so I can fix the conflicts, and move the selector the fields object

@magick93
Copy link
Contributor Author

@nfcampos

I couldnt find the checkbox - but merge conflicts should be resolved now.

@nfcampos nfcampos changed the base branch from main to nc/cheerio-selector-merge April 13, 2023 08:42
@nfcampos nfcampos merged commit a982bd9 into langchain-ai:nc/cheerio-selector-merge Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants