Change default Metaphor search example to use prompt optimizer #8890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffzwang
commented
Aug 7, 2023
jeffzwang
commented
- fix install command
- change example notebook to use Metaphor autoprompt by default
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hwchase17
reviewed
Aug 7, 2023
| "def search(query: str):\n", | ||
| " \"\"\"Call search engine with a query.\"\"\"\n", | ||
| " return client.search(query)\n", | ||
| " \"\"\"Call search engine with a query. Use autoprompt by default to convert query to a Metaphor query.\"\"\"\n", |
There was a problem hiding this comment.
i actually think its BAD to put this in the docstring - the agent sees this docstring and this isnt a super relevant fact and could distract from the true parameters
Could add that note in a comment
speaking of, may be good to add a comment about docstrings mattering haha
There was a problem hiding this comment.
Ah yes good point - I haven't played with this tool decorator syntax before, but obviously makes sense why that is the case. I guess I would like to have one comment that is the docstring and another that describes what the docstring does haha.
hwchase17
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.