Add BGE embeddings support #8848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
hwchase17
reviewed
Aug 7, 2023
|
The only difference is it requires a prompt for retrieval like the Instructor models.
…________________________________
From: Harrison Chase ***@***.***>
Sent: Monday, August 7, 2023 2:56:19 PM
To: langchain-ai/langchain ***@***.***>
Cc: manmax31 ***@***.***>; Author ***@***.***>
Subject: Re: [langchain-ai/langchain] Add BGE embeddings support (PR #8848)
@hwchase17 commented on this pull request.
are there any differences between this class and the normal huggingface class?
—
Reply to this email directly, view it on GitHub<#8848 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAU7ATYXVMA5B26ZOQRRYXLXUBYPHANCNFSM6AAAAAA3GMU3L4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
ah, and we cant use the instructor embeddings cause different package and everything? |
|
Yes.
Good thing is Bge supports sentence transformers.
Would have been cleaner if instructor supported sentence transformers as well.
On the other hand, Bge also has their own https://github.com/FlagOpen/FlagEmbedding/tree/master
…________________________________
From: Harrison Chase ***@***.***>
Sent: Monday, August 7, 2023 3:21:35 PM
To: langchain-ai/langchain ***@***.***>
Cc: manmax31 ***@***.***>; Author ***@***.***>
Subject: Re: [langchain-ai/langchain] Add BGE embeddings support (PR #8848)
ah, and we cant use the instructor embeddings cause different package and everything?
—
Reply to this email directly, view it on GitHub<#8848 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAU7AT6XZATE7CRHX25XEADXUB3N7ANCNFSM6AAAAAA3GMU3L4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
hwchase17
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.