Skip to content

Gpapp/chromadb #7891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2023
Merged

Gpapp/chromadb #7891

merged 5 commits into from
Jul 19, 2023

Conversation

gpapp
Copy link
Contributor

@gpapp gpapp commented Jul 18, 2023

For attention of

@vercel
Copy link

vercel bot commented Jul 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 18, 2023 11:57pm

@baskaryan
Copy link
Collaborator

cc @jeffchuber

@jeffchuber
Copy link
Contributor

@baskaryan we are good for this ... we would like to upgrade the default version for new users as in https://github.com/hwchase17/langchain/pull/7749/files however. how do you think we should merge these?

@jeffchuber
Copy link
Contributor

@baskaryan our preference would be to migrate users to the new system however. strong opinion loosely held. all new updates will be to ^0.4.0

@baskaryan
Copy link
Collaborator

@baskaryan our preference would be to migrate users to the new system however. strong opinion loosely held. all new updates will be to ^0.4.0

down to land this then #7749, that way we get both? new users get latest, old users don't see things break

@baskaryan baskaryan added lgtm and removed lgtm labels Jul 18, 2023
baskaryan
baskaryan reviewed Jul 18, 2023
View reviewed changes
langchain/vectorstores/chroma.py Outdated

# Maintain backwards compatibility with chromadb < 0.4.0
major, minor, _ = chromadb.__version__.split(".")
if int(major) >= 0 and int(minor) < 4:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpapp is this supposed to be int(major) == 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it is! Good spot, I managed to miss that in the rush.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to land this and #7749 once this change lands

@baskaryan baskaryan merged commit 1024637 into langchain-ai:master Jul 19, 2023
@jeffchuber jeffchuber mentioned this pull request Jul 19, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baskaryan baskaryan baskaryan left review comments

+1 more reviewer

@jeffchuber jeffchuber jeffchuber left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpapp @baskaryan @jeffchuber