Skip to content

refactor(core): overload convert_to_openai_messages for clear typing #32563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmaillefaud
Copy link
Contributor

Description

Add an overload to convert_to_openai_messages for better type checking.

@jmaillefaud jmaillefaud requested a review from eyurtsev as a code owner August 15, 2025 16:13
Copy link

vercel bot commented Aug 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Aug 15, 2025 10:10pm

Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed WallTime Performance Report

Merging #32563 will not alter performance

Comparing jmaillefaud:patch-1 (27e9cb6) with master (d3d23e2)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed Instrumentation Performance Report

Merging #32563 will not alter performance

Comparing jmaillefaud:patch-1 (27e9cb6) with master (d3d23e2)

Summary

✅ 14 untouched benchmarks

@mdrxy mdrxy changed the title style(core): overload convert_to_openai_messages for clear typing refactor(core): overload convert_to_openai_messages for clear typing Aug 15, 2025
@mdrxy mdrxy added the core Related to the package `langchain-core` label Aug 15, 2025
@mdrxy mdrxy added the linting Linting, formatting, or typing label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the package `langchain-core` linting Linting, formatting, or typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants