Skip to content

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Aug 5, 2025

No description provided.

mdrxy and others added 4 commits July 28, 2025 10:39
Co-authored-by: Maxime Grenu <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: jmaillefaud <[email protected]>
Co-authored-by: Eugene Yurtsev <[email protected]>
Co-authored-by: tanwirahmad <[email protected]>
Co-authored-by: Christophe Bornet <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: niceg <[email protected]>
Co-authored-by: Chaitanya varma <[email protected]>
Co-authored-by: dishaprakash <[email protected]>
Co-authored-by: Chester Curme <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Kanav Bansal <[email protected]>
Co-authored-by: Aleksandr Filippov <[email protected]>
Co-authored-by: Alex Feel <[email protected]>
# Conflicts:
#	.github/workflows/_integration_test.yml
#	.github/workflows/_release.yml
#	.github/workflows/api_doc_build.yml
#	.github/workflows/people.yml
#	.github/workflows/run_notebooks.yml
#	.github/workflows/scheduled_test.yml
#	SECURITY.md
#	docs/docs/integrations/vectorstores/pgvectorstore.ipynb
#	libs/langchain_v1/langchain/chat_models/base.py
#	libs/langchain_v1/tests/integration_tests/chat_models/test_base.py
#	libs/langchain_v1/tests/unit_tests/chat_models/test_chat_models.py
Co-authored-by: Mason Daugherty <[email protected]>
Co-authored-by: Eugene Yurtsev <[email protected]>
Co-authored-by: Mason Daugherty <[email protected]>
Co-authored-by: Nuno Campos <[email protected]>
Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2025 7:19pm

Copy link

codspeed-hq bot commented Aug 5, 2025

CodSpeed WallTime Performance Report

Merging #32418 will degrade performances by 12.33%

Comparing wip-v0.4 (281488a) with master (ee4c251)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 2 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_import_time[InMemoryVectorStore] 242.1 ms 272.1 ms -11.01%
test_import_time[LangChainTracer] 408.5 ms 466 ms -12.33%

Copy link

codspeed-hq bot commented Aug 5, 2025

CodSpeed Instrumentation Performance Report

Merging #32418 will not alter performance

Comparing wip-v0.4 (281488a) with master (ee4c251)

Summary

✅ 8 untouched benchmarks
⁉️ 6 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ test_stream_time 1.1 s N/A N/A
⁉️ test_stream_time 936.4 ms N/A N/A
⁉️ test_stream_time 1.1 s N/A N/A
⁉️ test_init_time 1.7 s N/A N/A
⁉️ test_init_time 17.1 ms N/A N/A
⁉️ test_init_time 17.2 ms N/A N/A

@@ -56,6 +56,8 @@ langchain-tests = { path = "../../standard-tests", editable = true }

[tool.mypy]
disallow_untyped_defs = "True"
disable_error_code = ["typeddict-unknown-key"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this better than per-line ignores?

@ccurme ccurme had a problem deploying to Scheduled testing August 5, 2025 19:43 — with GitHub Actions Failure
@ccurme ccurme had a problem deploying to Scheduled testing August 5, 2025 19:46 — with GitHub Actions Failure
@ccurme ccurme had a problem deploying to Scheduled testing August 5, 2025 19:47 — with GitHub Actions Failure
@ccurme ccurme temporarily deployed to Scheduled testing August 5, 2025 19:48 — with GitHub Actions Inactive
@ccurme ccurme temporarily deployed to Scheduled testing August 5, 2025 19:58 — with GitHub Actions Inactive
@ccurme ccurme temporarily deployed to Scheduled testing August 5, 2025 20:10 — with GitHub Actions Inactive
@mdrxy mdrxy added the release label Aug 6, 2025
mdrxy and others added 5 commits August 6, 2025 17:57
Adds backward compat for `.text()` on messages while keeping `.text`
access

_The kicker:_

Any previous use of `.text()` will now need a `# type: ignore[operator]`
to silence type checkers. However, it will still behave as expected at
runtime. Deprecating in v0.4.0, to be removed in v2.0.0.
To prevent polluting future PRs
# Conflicts:
#	libs/core/langchain_core/version.py
#	libs/core/pyproject.toml
#	libs/core/uv.lock
#	libs/partners/openai/tests/integration_tests/chat_models/test_responses_api.py
#	libs/partners/openai/uv.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants