feat(langchain): add stuff and map reduce chains #32333
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
CodSpeed WallTime Performance ReportMerging #32333 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32333 will not alter performanceComparing Summary
|
eyurtsev
force-pushed
the
eugene/add_summarization_chains
branch
2 times, most recently
from
948aec1 to
5e6c1e8
Compare
| from langchain_core.documents import Document | ||
|
|
||
|
|
||
| def format_document_xml(doc: Document) -> str: |
There was a problem hiding this comment.
expose in documents as format_as_xml?
There was a problem hiding this comment.
I like _ prefixed files in _internal as well
| __all__ = [ | ||
| "RunnableCallable", | ||
| ] |
There was a problem hiding this comment.
Hmm. I really think we should avoid using this if possible.
| ) | ||
|
|
||
| # Needs to be in global scope as the type annotation is used at runtime | ||
| from langchain_core.documents import Document as Document |
There was a problem hiding this comment.
| from langchain_core.documents import Document as Document | |
| from langchain_core.documents import Document |
There was a problem hiding this comment.
Be more specific w/ comment here - by pydantic I presume. Where? In schema gen?
| ], | ||
| ] = "default_reducer", | ||
| context_schema: ContextT = None, | ||
| response_format: Optional[type[BaseModel]] = None, |
There was a problem hiding this comment.
Let's use new syntax for unions bc we use from __future__ import annotations, so we can use |. There's a ruff rule to enforce
There was a problem hiding this comment.
Also we will drop 3.9 super soon anyways.
| ] = "default_reducer", | ||
| context_schema: ContextT = None, | ||
| response_format: Optional[type[BaseModel]] = None, | ||
| ) -> StateGraph[MapReduceState, ContextT, InputSchema, OutputSchema]: |
There was a problem hiding this comment.
Glad this is coming in handy :)
|
|
||
|
|
||
| class _Extractor(Generic[ContextT]): | ||
| """Stuff documents chain implementation. |
There was a problem hiding this comment.
Remove "stuff" right?
There was a problem hiding this comment.
We need to rename for a better name.
Could be create_document_analyzer
eyurtsev
force-pushed
the
eugene/add_summarization_chains
branch
from
e3de85d to
3bc07fd
Compare
eyurtsev
changed the title
There was a problem hiding this comment.
I can make these public in langgraph if it'd help you out 🫡, easy to fix later though bc internal
Uh oh!
There was an error while loading. Please reload this page.