Skip to content

chore(langchain): add ruff rules D100 and D104 #32142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Jul 21, 2025

Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain ⬜️ Ignored Preview Aug 13, 2025 0:52am

Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed WallTime Performance Report

Merging #32142 will not alter performance

Comparing cbornet:langchain-ruff-d100 (b6207f8) with master (024422e)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

from langchain.tools.retriever import create_retriever_tool
"""Moved to langchain_core.tools."""

from langchain_core.tools import create_retriever_tool
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified this redirection.

Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed Instrumentation Performance Report

Merging #32142 will not alter performance

Comparing cbornet:langchain-ruff-d100 (b6207f8) with master (024422e)

Summary

✅ 14 untouched benchmarks

@cbornet cbornet force-pushed the langchain-ruff-d100 branch from e35c7fa to ecf9f32 Compare July 21, 2025 14:57
@cbornet
Copy link
Collaborator Author

cbornet commented Jul 21, 2025

The PR is huge.
LMK if you prefer smaller ones. Eg. first fixing for langchain.vectorstores, then another one for langchain.retrievers, etc...

@mdrxy mdrxy added the linting Linting or formatting label Jul 22, 2025
@cbornet cbornet force-pushed the langchain-ruff-d100 branch 2 times, most recently from 0a6eac6 to 75ebbf6 Compare July 25, 2025 22:08
@cbornet cbornet changed the title feat(langchain): add ruff rules D100 and D104 chore(langchain): add ruff rules D100 and D104 Jul 25, 2025
@cbornet cbornet force-pushed the langchain-ruff-d100 branch from 75ebbf6 to ee06276 Compare July 28, 2025 11:28
@cbornet cbornet force-pushed the langchain-ruff-d100 branch from 598b72e to be3c5cd Compare August 13, 2025 12:49
@cbornet cbornet force-pushed the langchain-ruff-d100 branch from be3c5cd to b6207f8 Compare August 13, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting Linting or formatting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants