Skip to content

Conversation

e7217
Copy link
Contributor

@e7217 e7217 commented Mar 20, 2025

Hello!
I have reopened a pull request for tool integration.
Please refer to the previous PR.

I understand that for the tool integration, a separate package should be created, and only the documentation should be added under docs/docs/. If there are any other procedures, please let me know.

langchain-naver-community

cc: @ccurme

@dosubot dosubot bot added the size:L label Mar 20, 2025
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2025 3:46pm

@e7217
Copy link
Contributor Author

e7217 commented Mar 23, 2025

@ccurme Could you check this PR?

"\n",
"### Tool features\n",
"\n",
"**Search** : The Naver Search Tool provides a simple interface to search Naver and get results: \n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence ends abruptly.

Copy link
Contributor Author

@e7217 e7217 Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback.

"source": [
"query = \"What is the weather in Seoul?\"\n",
"result = agent_executor.invoke({\"messages\": [(\"human\", query)]})\n",
"result[\"messages\"][-1].content"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"result[\"messages\"][-1].content"
"result[\"messages\"][-1].pretty_print()"

Might be nice to run this to show output!

@dosubot dosubot bot added the lgtm label Mar 23, 2025
@ccurme ccurme merged commit e2d9fe7 into langchain-ai:master Mar 23, 2025
13 checks passed
@e7217 e7217 deleted the feat/add-tool-naver-community branch March 23, 2025 23:45
@ccurme
Copy link
Collaborator

ccurme commented Apr 22, 2025

@e7217 Naver has recently published an official langchain-naver package: https://github.com/NaverCloudPlatform/langchain-naver

You might consider collaborating with them to see if it makes sense to consolidate what's in langchain-naver-community into their package (e.g., by opening an issue to discuss).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants