Skip to content

Conversation

@fedeoliv
Copy link
Contributor

@fedeoliv fedeoliv commented Oct 20, 2024

This PR introduces a new azure_ad_async_token_provider attribute to the AzureOpenAI and AzureChatOpenAI classes in partners/openai and community packages, given it's currently supported on openai package as AsyncAzureADTokenProvider type.

The reason for creating a new attribute is to avoid breaking changes. Let's say you have an existing code that uses a AzureOpenAI or AzureChatOpenAI instance to perform both sync and async operations. The azure_ad_token_provider will work exactly as it is today, while azure_ad_async_token_provider will override it for async requests.

@vercel
Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2024 2:23am

Copy link
Contributor

@vbarda vbarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm label Oct 22, 2024
@vbarda vbarda enabled auto-merge (squash) October 22, 2024 21:42
@vbarda vbarda merged commit ab205e7 into langchain-ai:master Oct 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants