feat: sandbox protocol #319
Open
+707
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
reviewed
Nov 6, 2025
| custom_tool_descriptions = {} | ||
| tools = [] | ||
|
|
||
| for tool_name, tool_generator in TOOL_GENERATORS.items(): |
Collaborator
There was a problem hiding this comment.
dont we want to check if exec is supported by backend, and then optionally add or not add here? rather than check inside tool?
Collaborator
Author
There was a problem hiding this comment.
It's one of the places where the abstraction leaks for the factory -- I'll add conditional logic to simplify the non factory case
| self, | ||
| command: str, | ||
| *, | ||
| timeout: int = 30 * 60, |
Collaborator
There was a problem hiding this comment.
this doesnt seem used? remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.