Fix header sizing issue #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue originates from mixing row heights (as returned by `ui.text_style_height()` and font size. This PR fixes this discrepancy, leading to correct (relative) header sizing.
This was referenced Nov 7, 2023
Owner
|
Thanks! |
abey79
added a commit
to rerun-io/rerun
that referenced
this pull request
Nov 8, 2023
### What - Take advantage of lampsitter/egui_commonmark#20 to use "correct" headings in in-app quick start guides. - Bump egui_commonmark to 0.9.2 which includes the PR above - Fixes #3612 <img width="1305" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/a4befe22-2675-4a8f-a5ca-38cec3141b13"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4178) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4178) - [Docs preview](https://rerun.io/preview/85986f760b9d674ecb58917f1b77693f43d3c3bf/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/85986f760b9d674ecb58917f1b77693f43d3c3bf/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue originates from mixing row heights (as returned by
ui.text_style_height()) and font sizes, which appear to be slightly different things. This PR fixes this discrepancy, leading to correct (relative) header sizing.