-
-
Notifications
You must be signed in to change notification settings - Fork 43
Introduce HelperPluginManagerInterface
#330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In order to have a simple way to reset all state that has built up in view helpers / plugins, the plugin manager overrides `Container::get` to populate a list of stateful plugins that have been used during the rendering cycle. Also re-writes "Advanced Usage", de-emphasising MVC related docs. Signed-off-by: George Steel <[email protected]>
Ocramius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my PoV, this is a very welcome addition. Would still want other opinions before proceeding with this design, though: in other environments I worked with, the entire container was being rebuilt (which is also a fine approach)
| * Resets the internal state built up in any view helpers so that further rendering cycles are not polluted | ||
| */ | ||
| public function resetState(): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very welcome addition 👍
|
My plan here is hopefully to drop "Rendering Strategies" and the Plugin Managers don't provide any way to reset/clear built services AFAIK, nor extract config, so that would need to implemented over there first if tearing down the container was the preferred route. |
weierophinney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real code changes, but some doc changes.
But this was a primary reason why I moved away from laminas-view some time ago, so this will definitely be welcome!
Co-authored-by: Matthew Weier O'Phinney <[email protected]> Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
…formance Signed-off-by: George Steel <[email protected]>
|
Anyone have any objections if I merge this? Looks like all feedback is resolved |
froschdesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
|
(I will recheck the documentation before the final release.) |
In order to have a simple way to reset all state that has built up in view helpers / plugins, the plugin manager overrides
Container::getto populate a list of stateful plugins that have been used during the rendering cycle.Also re-writes "Advanced Usage", de-emphasising MVC related docs.