fix(l1): restore datadir path #4050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
approved these changes
Aug 14, 2025
rodrigo-o
approved these changes
Aug 14, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** PR lambdaclass#4024 changed how we initialize the datadir. Instead of looking for the database in a path relative to the home directory (ie: .local/share/datadir on linux) it now looks for it on the path relative to the current directory (ie: ethrex/datadir). This caused problems when updating the ethrex commit on currently running ethrex nodes due to the DB mismatch. This PR restores the previous behaviour, and has been confirmed to work as usual on the aforementioned ethrex nodes. <!-- Why does this pull request exist? What are its goals? --> **Description** * Restore where we look for the datadir (relative to home vs current dir) <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes None, but is needed to continue lambdaclass#1676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #4024 changed how we initialize the datadir. Instead of looking for the database in a path relative to the home directory (ie: .local/share/datadir on linux) it now looks for it on the path relative to the current directory (ie: ethrex/datadir). This caused problems when updating the ethrex commit on currently running ethrex nodes due to the DB mismatch.
This PR restores the previous behaviour, and has been confirmed to work as usual on the aforementioned ethrex nodes.
Description
Closes None, but is needed to continue #1676