chore(l1): improve log message when trying to run incompatible configs #4022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible configurations.
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling by replacing a panic with a proper error return when the Store is initialized with a genesis configuration that differs from what's already stored in the database. The change provides a clearer, more actionable error message for users encountering configuration mismatches.
- Replaces panic behavior with proper error handling using
StoreError::Custom - Updates the error message to be more user-friendly and informative
- Adjusts corresponding test to verify error handling instead of panic catching
Lines of code reportTotal lines added: Detailed view |
MegaRedHand
approved these changes
Aug 12, 2025
Oppen
approved these changes
Aug 12, 2025
JereSalo
reviewed
Aug 12, 2025
crates/storage/store.rs
Outdated
| Some(_) => panic!("{GENESIS_DIFF_PANIC_MESSAGE}"), | ||
| Some(_) => { | ||
| error!( | ||
| "The chain configuration stored in the database is incompatible with the provided configuration. If you intended to switch networks, clear the database (e.g., run `ethrex removedb`) and try again." |
There was a problem hiding this comment.
The user could also specify another datadir without needing to remove the db, right? Do you think we should specify this here so that they know they have another alternative if they don't want to remove the current database?
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
lambdaclass#4022) **Motivation** Current error message was confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current error message was confusing.