feat(l1): embed bootnodes for public networks inside binary #3967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR embeds bootnode configuration files directly into the binary instead of reading them from the filesystem at runtime. This enables users to run the binary without needing external bootnode files for public networks (Holesky, Sepolia, Hoodi, and Mainnet).
Key Changes:
- Replaced lazy_static declarations with embedded string constants using
include_str! - Added a new
get_bootnodes()method to the Network enum for parsing embedded bootnode data - Simplified the bootnode loading logic in the initializers module
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/ethrex/networks.rs | Replaced lazy_static bootnode loading with embedded strings and added get_bootnodes() method |
| cmd/ethrex/initializers.rs | Simplified bootnode loading to use the new get_bootnodes() method |
Lines of code reportTotal lines added: Detailed view |
fmoletta
approved these changes
Aug 6, 2025
Closed
LeanSerra
pushed a commit
that referenced
this pull request
Aug 12, 2025
**Motivation** We want users to be able to run the binary without needing to have a file of known bootnodes for each public network. **Description** This PR embeds the bootnode files inside the binary. Closes #3966
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…ass#3967) **Motivation** We want users to be able to run the binary without needing to have a file of known bootnodes for each public network. **Description** This PR embeds the bootnode files inside the binary. Closes lambdaclass#3966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want users to be able to run the binary without needing to have a file of known bootnodes for each public network.
Description
This PR embeds the bootnode files inside the binary.
Closes #3966