Skip to content

Conversation

@fspindle
Copy link
Contributor

  • Checking for PCL version using PCL_VERSION_COMPARE provided by PCL in pcl/pcl_config.h like #if PCL_VERSION_COMPARE(>=, 1, 7, 2) allows to build ViSP libraries but not the Python bindings.
    There is the following error:
    Successfully installed visp_python_bindgen-0.0.1
     18%|████████████████████████████████▎                                               | 68/373   [00:04<00:09, 32.93hdr/s]
    bindings/src/tmp/vpImageConvert.h.in:353 error: Could not evaluate expression due to SyntaxError("around token '>=' type CPP_GREATEREQUAL") (passed to evaluator: 'PCL_VERSION_COMPARE(>=,1,14,1)')
    bindings/src/tmp/vpImageConvert.h.in:396 error: Could not evaluate expression due to SyntaxError("around token '>=' type CPP_GREATEREQUAL") (passed to evaluator: 'PCL_VERSION_COMPARE(>=,1,14,1)')
    
  • Using instead VISP_HAVE_PCL_VERSION defined in vpConfig.h does the trick (like for OpenCV, Ogre, libfranka...)

- Checking for PCL version using PCL_VERSION_COMPARE provided by PCL in pcl/pcl_config.h like
  #if PCL_VERSION_COMPARE(>=, 1, 7, 2)
  allows to build ViSP libraries but not the Python bindings
  There is the following error:
  ```
  Successfully installed visp_python_bindgen-0.0.1
   18%|████████████████████████████████▎                                               | 68/373 [00:04<00:09, 32.93hdr/s]bindings/src/tmp/vpImageConvert.h.in:353 error: Could not evaluate expression due to SyntaxError("around token '>=' type CPP_GREATEREQUAL") (passed to evaluator: 'PCL_VERSION_COMPARE(>=,1,14,1)')
bindings/src/tmp/vpImageConvert.h.in:396 error: Could not evaluate expression due to SyntaxError("around token '>=' type CPP_GREATEREQUAL") (passed to evaluator: 'PCL_VERSION_COMPARE(>=,1,14,1)')
  ```
- Using VISP_HAVE_PCL_VERSION defined in vpConfig.h does the trick (like for OpenCV, Ogre, libfranka...)
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.93%. Comparing base (75c4d90) to head (253f151).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
+ Coverage   47.91%   47.93%   +0.01%     
==========================================
  Files         531      531              
  Lines       68596    68596              
  Branches    31985    31985              
==========================================
+ Hits        32866    32879      +13     
+ Misses      31748    25374    -6374     
- Partials     3982    10343    +6361     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fspindle fspindle merged commit 7a12cec into lagadic:master Nov 21, 2025
84 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant