-
Couldn't load subscription status.
- Fork 9
Adds inactive state to the Step #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two questions before I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just one comment!
src/components/Stepper/Step.tsx
Outdated
| @@ -1,10 +1,11 @@ | |||
| import React, { CSSProperties } from 'react' | |||
|
|
|||
| import { isNil } from 'lodash' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have time, I believe it would be better to put this inside a wrapper in https://github.com/laboratoriobridge/bold/blob/main/src/util/index.ts, as was done with other functions.
With this wrapper, it will be easier to change the provider of the function in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! ✔️
closes #923
This PR adds a new
inactivestate for the Step.