Skip to content

Conversation

@diegoasmello
Copy link
Contributor

@diegoasmello diegoasmello commented Sep 8, 2025

closes #923

This PR adds a new inactive state for the Step.

@diegoasmello diegoasmello changed the title Adds inactive state to the step Adds inactive state to the Step Sep 8, 2025
Copy link
Contributor

@lucasjoao lucasjoao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two questions before I approve.

Andrevmatias
Andrevmatias previously approved these changes Sep 11, 2025
Copy link
Contributor

@Andrevmatias Andrevmatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@Andrevmatias Andrevmatias removed their assignment Sep 11, 2025
lucasjoao
lucasjoao previously approved these changes Sep 12, 2025
Copy link
Contributor

@lucasjoao lucasjoao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just one comment!

@@ -1,10 +1,11 @@
import React, { CSSProperties } from 'react'

import { isNil } from 'lodash'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have time, I believe it would be better to put this inside a wrapper in https://github.com/laboratoriobridge/bold/blob/main/src/util/index.ts, as was done with other functions.

With this wrapper, it will be easier to change the provider of the function in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! ✔️

@lucasjoao lucasjoao removed their assignment Sep 12, 2025
@diegoasmello diegoasmello merged commit 83b037b into main Sep 16, 2025
2 checks passed
@diegoasmello diegoasmello deleted the 923-stepper branch September 16, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Stepper] Updating the component adding a step status

5 participants