Avoid comparing an ndarray with a str in set_component_colors #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushalkolar
reviewed
Jul 17, 2025
| @@ -908,7 +908,7 @@ def set_component_colors( | |||
| n_contours = len(self._image_widget.gridplot[0, 0]["contours"]) | |||
|
|
|||
| # use the random colors | |||
| if metric == "random": | |||
| if isinstance(metric, str) and metric == "random": | |||
There was a problem hiding this comment.
I think this can still fail if it's an array since it will try both conditions and an array will both fail?
suggestion:
if isinstance(metric, str):
if metric == "random"
There was a problem hiding this comment.
Huh? If it's an array, isintance(metric, str) will be false and it will short-circuit, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix here - there is a bug in
set_component_colorswhere if you try to use the feature of passing an ndarray as a metric, it fails with "The truth value of an array with more than one element is ambiguous." I just changed the order of the if statement to avoid this. This feature probably is not used very often, but I was trying to take advantage of it in my subclass ofCNMFVizContainerand ran into the bug.I also checked and it looks like this should not conflict with the mega-PR #45.