-
Notifications
You must be signed in to change notification settings - Fork 82
fix: use mholt/archives
#2738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: use mholt/archives
#2738
Conversation
Replaced the deprecated mholt/archiver with the new mholt/archives, in the process addressing security vulnerability CVE-2025-3445. See: https://nvd.nist.gov/vuln/detail/CVE-2025-3445
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
18396384 | Triggered | Username Password | 2c37181 | container-engine-lib/lib/backend_impls/docker/docker_manager/docker_auth_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Description
A critical security vulnerability was found in a library we used for archiving,
mholt/archiver
: https://nvd.nist.gov/vuln/detail/CVE-2025-3445.mholt/archiver
is deprecated so it hasn't been updated with a fix.This PR upgrades Kurtosis to use the successor of that library
mholt/archives
. Additionally, since the new archives library does not contain anUnarchive
function, it borrows anUnarchive
implementation from this library -https://github.com/jm33-m0/arcIs this change user facing?
NO
References
Original change from 677cf9f @scharissis