Feat/support deployment user services public #2726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GlacierWalrus <[email protected]>
tedim52
reviewed
Apr 22, 2025
| memoryAllocationMegabytes, | ||
| minCpuMilliCores, | ||
| minMemoryMegaBytes, | ||
| kubernetesConfig, |
There was a problem hiding this comment.
neat trick to get all kubernetes config for free
tedim52
reviewed
Apr 22, 2025
| @@ -554,6 +554,130 @@ | |||
| "type": "ReadyCondition", | |||
| "content": "ready_conditions?", | |||
| "detail": "This field can be used to check the service's readiness after this is started to confirm that it is ready to receive connections and traffic" | |||
| }, | |||
There was a problem hiding this comment.
nice! lsp hasn't been updated in a while, should make a ticket to support missing configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few fixes to support some productionisation in kubernetes.
I made the changes for my own deployment, it probably needs some tidying up prior to merging, but I thought I would share in case it benefits anyone.
The changes supports
REMINDER: Tag Reviewers, so they get notified to review
Is this change user facing?
YES
References (if applicable)
#2610
And probably some others?
I've deployed a testnet using this fork, referring to a personal fork of the ethereum-package here