KDB-850 add certificate validity period metrics #5112
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylorph
force-pushed
the
ylorph/cert_metric
branch
from
1d6eacb to
ef12985
Compare
Qodana for .NET4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
alexeyzimarev
requested changes
May 26, 2025
| new(Tags.SerialNumber, cert.GetSerialNumberString()), | ||
| new(Tags.Thumbprint, cert.Thumbprint), | ||
| new(Tags.ValidityPeriod, ValidityPeriod(DateTimeOffset.FromUnixTimeSeconds(clock.SecondsSinceEpoch).DateTime, cert.NotBefore, cert.NotAfter).ToString()) | ||
|
|
There was a problem hiding this comment.
Could you please reformat the file (add empty lines between classes, remove redundant empty lines)?
alexeyzimarev
requested changes
May 26, 2025
| new(Tags.SerialNumber, cert.GetSerialNumberString()), | ||
| new(Tags.Thumbprint, cert.Thumbprint), | ||
| new(Tags.ValidityPeriod, ValidityPeriod(DateTimeOffset.FromUnixTimeSeconds(clock.SecondsSinceEpoch).DateTime, cert.NotBefore, cert.NotAfter).ToString()) | ||
|
|
|
How does it get wired up with the meter? |
|
Also, we need to add the new metrics to the docs (metrics page) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.